[PATCH] D83523: MachineSink: permit sinking into INLINEASM_BR indirect targets

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 11:53:25 PDT 2020


jyknight added a comment.

INLINEASM_BR already returns true for hasUnmodeledSideEffects(), so the diff above doesn't change anything.

The bug is in TwoAddressInstructinoPass::sink3AddrInstruction, which doesn't query _ANY_ of these predicates. I've just uploaded https://reviews.llvm.org/D83708 to remove the function entirely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83523/new/

https://reviews.llvm.org/D83523





More information about the llvm-commits mailing list