[PATCH] D83709: [NFC] Add 'override' keyword where missing in include/ and lib/.
Logan Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 13 11:51:36 PDT 2020
logan-5 created this revision.
logan-5 added a reviewer: lattner.
logan-5 added a project: LLVM.
Herald added subscribers: llvm-commits, kerbowa, Jim, kbarton, aheejin, hiraditya, sbc100, nhaehnle, jvesely, nemanjai, dylanmckay, arsenm.
This fixes warnings raised by Clang's new `-Wsuggest-override`, in preparation for enabling that warning in the LLVM build.
This patch also removes the `virtual` keyword where redundant, but only in places where doing so improves consistency within a given file. It also removes a couple unnecessary virtual destructor declarations in derived classes where the destructor inherited from the base class is already virtual.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D83709
Files:
llvm/include/llvm/Analysis/InstructionPrecedenceTracking.h
llvm/include/llvm/Analysis/MustExecute.h
llvm/include/llvm/Demangle/MicrosoftDemangleNodes.h
llvm/include/llvm/IR/DiagnosticInfo.h
llvm/include/llvm/MC/MCELFObjectWriter.h
llvm/include/llvm/MC/MCMachObjectWriter.h
llvm/include/llvm/MC/MCWasmObjectWriter.h
llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
llvm/include/llvm/Object/Error.h
llvm/include/llvm/Support/FormatAdapters.h
llvm/lib/Analysis/LazyValueInfo.cpp
llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
llvm/lib/Target/AMDGPU/MCTargetDesc/R600MCCodeEmitter.cpp
llvm/lib/Target/AVR/AVRFrameLowering.cpp
llvm/lib/Target/AVR/AsmParser/AVRAsmParser.cpp
llvm/lib/Target/BPF/BTFDebug.h
llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp
llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.h
llvm/lib/Target/X86/X86TargetTransformInfo.h
llvm/lib/Transforms/Utils/FixIrreducible.cpp
llvm/lib/Transforms/Utils/PredicateInfo.cpp
llvm/lib/Transforms/Utils/UnifyLoopExits.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83709.277509.patch
Type: text/x-patch
Size: 26999 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200713/9dd14147/attachment.bin>
More information about the llvm-commits
mailing list