[PATCH] D83703: [flang] Use octal escapes for character literals in modfiles

[Peter Klausler via Phabricator via llvm-commits]

klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/lib/Semantics/mod-file.cpp:108
+
+ModFileWriter::~ModFileWriter() {
+  parser::useHexadecimalEscapeSequences = saveUseHexadecimalEscapeSequences_;
----------------
Could use `common::Restorer` here instead of a flag and a destructor.


================
Comment at: flang/lib/Semantics/mod-file.h:35
 public:
-  ModFileWriter(SemanticsContext &context) : context_{context} {}
+  ModFileWriter(SemanticsContext &);
+  ~ModFileWriter();
----------------
nit: should be `explicit`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83703/new/

https://reviews.llvm.org/D83703