[PATCH] D83659: [flang][OpenMP] upstream OpenMP lowering

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Thanks @SouraVX for adding the lowering code for barrier.

Could you clarify in the commit message that the lowering is from parse-tree/pft to MLIR.

A few nits inline.



================
Comment at: flang/include/flang/Lower/OpenMP.h:35-40
+void genOMP(AbstractConverter &, pft::Evaluation &,
+            const parser::OpenMPStandaloneConstruct &);
+
+void genOMP(AbstractConverter &, pft::Evaluation &,
+            const parser::OpenMPSimpleStandaloneConstruct &);
+
----------------
Do these need to be visible outside?


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRDialect.h:45
     mlir::registerDialect<FIROpsDialect>();
+    mlir::registerDialect<mlir::omp::OpenMPDialect>();
     return true;
----------------
Are mlir dialects listed in alphabetical order? If so openmp dialect should also be.


================
Comment at: flang/lib/Lower/OpenMP.cpp:32
+  switch (directive.v) {
+
+  default:
----------------
is this line empty as per coding style or accidental?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83659/new/

https://reviews.llvm.org/D83659