[PATCH] D83288: [LV] Pick vector loop body as insert point for SCEV expansion.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D83288#2146282 <https://reviews.llvm.org/D83288#2146282>, @Ayal wrote:

> Good catch!
>
> The specific culprit for the pr is the call to SE.DT.dominates(EntInst, InsertPt) by SCEVExpander::FindValueInExprValueMap().
>
> Would probably be better to keep DT up to date as we go along, due to SE.DT's dependence on it, instead of fixing it after code-gen via updateDominatorTree(); but there was some reason for doing it this way(?).


Yes, ideally we would keep the DT up-to-date while vectorizing. It is a slightly bigger change though, mostly because we only patch up the CFG after vectorizing some blocks. I'll look into that as follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83288/new/

https://reviews.llvm.org/D83288