[PATCH] D83644: [AArch64][ELF] Support FDE references more than +/-2GB range for AArch64 large code model

weiwei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 09:37:40 PDT 2020


wwei marked an inline comment as done.
wwei added inline comments.


================
Comment at: llvm/test/MC/ELF/cfi-large-model.s:8
 // RUN:   -o - | llvm-readobj -S --sd | FileCheck --check-prefix=CHECK-PPC %s
-
+// RUN: llvm-mc -filetype=obj -triple aarch64-linux-gnu -large-code-model %s \
+// RUN:   -o - | llvm-readobj -S --sd | FileCheck --check-prefix=CHECK-ARM64 %s
----------------
MaskRay wrote:
> `-triple aarch64` is sufficient. This tests generic ELF behavior. Add -triple aarch64_be.
> 
> You can move aarch64 before x86_64 to be closer (oh,yes,x86_64->powerpc64le is an inversion pair) to an alphabetical order.
> 
using generic  `aarch64` and triple `aarch64_be` added. Here I keep the original reverse order so that it don't need to change the order of the large chunk of test code


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83644/new/

https://reviews.llvm.org/D83644





More information about the llvm-commits mailing list