[PATCH] D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local

[Victor Huang via Phabricator via llvm-commits]

NeHuang added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:1038
 
   // FIXME: Remove the fatal error once the call protocol is implemented.
   if (type == R_PPC64_REL24_NOTOC && s.isInPlt())
----------------
nit: remove this comment 


================
Comment at: lld/ELF/Thunks.cpp:1007
          "unexpected relocation type for thunk");
+  if (type == R_PPC64_REL24_NOTOC && s.isInPlt())
+    return make<PPC64R12SetupStub>(s);
----------------
Shall we merge it with the `if` check below if it does not hurt the readability?
```
if (s.isInPlt())
  return (type == R_PPC64_REL24_NOTOC) ?  make<PPC64R12SetupStub>(s) : make<PPC64PltCallStub>(s);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83669/new/

https://reviews.llvm.org/D83669