[PATCH] D83578: [test] Replace a fragile lit feature (substitution in an argument place) with command -v

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 08:43:45 PDT 2020


MaskRay added a comment.

In D83578#2146713 <https://reviews.llvm.org/D83578#2146713>, @jhenderson wrote:

> No particular opinion on this change itself, and I might be misunderstanding some of hte comments, but I wouldn't want to see the feature of expanding tool names to full paths to be dropped, at least for some cases. It is useful to me when I'm debugging a test as I can copy the tool path straight from the lit output to the command I wish to execute to see what actually is happening/tweak stuff/make sure I'm running what I think I'm running etc.


The expansion to full paths will be retained at the command position but not argument positions. This is to emulate a shell.

(I haven't investigated enough about lit to understand the previous comment https://reviews.llvm.org/D83578#2145139 )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83578/new/

https://reviews.llvm.org/D83578





More information about the llvm-commits mailing list