[PATCH] D83670: [NFCI][InstCombine] Move store merging from `visitStoreInst()` into `visitUnconditionalBranchInst()`

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:2760
+  if (StoreInst *SI = GetLastSinkableStore(BasicBlock::iterator(BI)))
+    if (mergeStoreIntoSuccessor(*SI)) {
+      // Okay, we've managed to do that. Now, let's see if now-second-to-last
----------------
lebedev.ri wrote:
> nikic wrote:
> > Can we just `return &BI;` here, and let the usual reprocessing deal with it?
> .. or did you mean *always* `return &BI;` ?
Yeah, I meant always returning. That will try rerunning this code and will either find the next store to merge and do so, or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83670/new/

https://reviews.llvm.org/D83670