[PATCH] D83677: [analyzer] Rework Z3 requirements in the CSA testsuite

[Kristóf Umann via Phabricator via llvm-commits]

Szelethus added a comment.

I lack the confidence to accept this straight away, but the overall direction looks great. LGTM!

You're going to be very popular around here with these patches! :)



================
Comment at: clang/test/Analysis/trustnonnullchecker_test.m:1-3
-// Temporarily disabling the test, it failes the "system is over-constrained"
-// assertion in *non* optimized builds.
-// REQUIRES: rdar44992170
----------------
Why did you delete this? @NoQ, is D57062 related?


================
Comment at: clang/www/analyzer/checker_dev_manual.html:6
   <title>Checker Developer Manual</title>
   <link type="text/css" rel="stylesheet" href="menu.css">
   <link type="text/css" rel="stylesheet" href="content.css">
----------------
This menu is still not working, right?


================
Comment at: clang/www/analyzer/checker_dev_manual.html:548-550
+  The <tt>RECHECK_WITH_Z3_SOLVER</tt> parameter lets the testsuite to use both
+  constraint managers, which are substituted by the <tt>%clang_analyze_cc1</tt>
+  in each <tt>RUN</tt> line.
----------------
What is the difference in between clang_analyze_cc1 and clang_analyze_cc1_range then?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83677/new/

https://reviews.llvm.org/D83677