[PATCH] D83477: [Matrix] Tighten LangRef definitions and Verifier checks.

Mon Jul 13 03:12:57 PDT 2020

fhahn added a comment.

In D83477#2146889 <https://reviews.llvm.org/D83477#2146889>, @SjoerdMeijer wrote:

> > I think the intrinsic definition is wrong here (and it also seems like the LLVMAnyPointerType does not actually result in the expected check). I think should pass a pointer to the element type directly (rather than a pointer to a vector), because if stride > R we would access elements outside of the vector. Granted, nothing should really rely on the pointer type for aliasing purposes and so on, but it seems misleading to pass in e.g. <6 x i32>* and then access elements other than the first 6 i32, e.g. due to the stride being 10.
> > 
> > I missed that in the adjustments of the langref, I think we specify that %Ptr needs to be a pointer to the element type of the vector.
>
> Okay, cool, that's actually what I was expecting.
>  Just checking that I don't get into your way, shall I prepare a patch for that?

I don't mind. The current patch is reverted at the moment, right? So it might be easiest to just fold those small changes directly into it? Otherwise I can do it as follow-up once the current patch lands.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83477/new/

https://reviews.llvm.org/D83477