[PATCH] D83477: [Matrix] Tighten LangRef definitions and Verifier checks.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Had to revert this because somehow I missed a few failing regression test. Regarding this, wanted to check one thing @fhahn.

In `test/Transforms/LowerMatrixIntrinsics/strided-store-i32.ll`, we have for example:

  call void @llvm.matrix.column.major.store(<6 x i32> %in, i32* %out, ..

And I am thinking that this should be:

  call void @llvm.matrix.column.major.store(<6 x i32> %in, <6 x i32>* %out, ..

This would the intrinsic description which says that the second argument should be a pointer to the first matched type:

  [llvm_anyvector_ty, LLVMAnyPointerType<LLVMMatchType<0>>,

Agree, or am I perhaps missing something? If not and you agree, I will modify the loads/store tests in test/Transforms/LowerMatrixIntrinsics/ before recommitting this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83477/new/

https://reviews.llvm.org/D83477