[PATCH] D83554: [llvm-readobj] - Stop using unwrapOrError() for all program_headers() calls.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of suggestions.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-tags.test:645
+# RUN: llvm-readobj --dynamic-table %t-phentsize-err 2>&1 | \
+# RUN:   FileCheck %s -DFILE=%t-phentsize-err --check-prefixes=PHENTSIZE-WARN,PHENTSIZE-LLVM
+# RUN: llvm-readelf --dynamic-table %t-phentsize-err 2>&1 | \
----------------
Here and below, perhaps worth an `--implicit-check-not=warning:`?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-tags.test:647
+# RUN: llvm-readelf --dynamic-table %t-phentsize-err 2>&1 | \
+# RUN:  FileCheck %s -DFILE=%t-phentsize-err --check-prefixes=PHENTSIZE-WARN,PHENTSIZE-GNU
+
----------------
Nit: extra space for indent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83554/new/

https://reviews.llvm.org/D83554