[PATCH] D83626: [AMDGPU/MemOpsCluster] Guard new mem ops clustering heuristic logic by a flag

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 00:35:10 PDT 2020


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:103
+    "amdgpu-enable-new-mem-ops-cluster-heuristic",
+    cl::desc("Enable new heuristic for computing max mem ops cluster size"),
+    cl::init(false), cl::Hidden);
----------------
Is there a more useful description than "new heuristic"? If we're asking people to choose between two heuristics then the fact that one of them is currently "new" isn't really helpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83626/new/

https://reviews.llvm.org/D83626





More information about the llvm-commits mailing list