[PATCH] D83650: [FileCheck] Extend -dump-input with substitutions

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 12 20:41:02 PDT 2020


jdenny added a comment.

In D83650#2146534 <https://reviews.llvm.org/D83650#2146534>, @mehdi_amini wrote:

> I agree that I'd like to have more info inline and this is going in the right direction, but what seems missing is still the check line itself.
>
> Have you looked into localizing it as well?


I too have been thinking that would be a good idea.  However, it's a lower priority because, at least for tests I work with, `check:1` makes it easy to find that info in a file I have to open anyway.

> Ultimately with some scheme like this the following header can be entirely omitted:

Probably so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83650/new/

https://reviews.llvm.org/D83650





More information about the llvm-commits mailing list