[PATCH] D83010: [flang] Add inliner pass.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/include/flang/Optimizer/Transforms/Passes.h:43
+/// nodes as block arguments.
+std::unique_ptr<mlir::Pass> createMemToRegPass();
+
----------------
None of the above seem related to the inline to me?


================
Comment at: flang/include/flang/Optimizer/Transforms/Passes.td:51
+
+#endif // FLANG_OPTIMIZER_TRANSFORMS_PASSES
----------------
Here as well I don't understand how any of these is about inlining?


================
Comment at: flang/lib/Optimizer/Transforms/Inliner.cpp:18
+                       llvm::cl::desc("aggressively inline everything"),
+                       llvm::cl::init(false));
+
----------------
Ideally please favor "Pass options" instead of globals as much as possible (also keep in mind that global cl::opt are really for debugging)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83010/new/

https://reviews.llvm.org/D83010