[PATCH] D78741: [LLD][ELF][AVR] Implement the missing relocation types

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks for the update. All look good to me now.

In D78741#2146238 <https://reviews.llvm.org/D78741#2146238>, @aykevl wrote:

> - added `--print-imm-hex` (so this patch depends on D83634 <https://reviews.llvm.org/D83634>)
> - deleted some redundant parentheses
> - changed all comment markers to `;`
>
>   I've confirmed that `#` is not a valid comment char in the original AVR assembler. See: http://ww1.microchip.com/downloads/en/devicedoc/40001917a.pdf#page=12 (section 4.3). I don't know why `#` at the start of a line works as a comment, perhaps these lines are removed by llvm-lit?


MCParser supports `#` in the line beginning.

6.12 of the document you linked says "Unsurprisingly, this directive does exactly nothing. The only reason it exists is that it is required by the ANSI C standard" but I think that is not true. GCC/clang will report `error: invalid preprocessing directive`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78741/new/

https://reviews.llvm.org/D78741