[PATCH] D83288: [LV] Pick vector loop body as insert point for SCEV expansion.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 12 07:58:32 PDT 2020


Ayal added a comment.

Good catch!

The specific culprit for the pr is the call to SE.DT.dominates(EntInst, InsertPt) by SCEVExpander::FindValueInExprValueMap().

Would probably be better to keep DT up to date as we go along, due to SE.DT's dependence on it, instead of fixing it after code-gen via updateDominatorTree(); but there was some reason for doing it this way(?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83288/new/

https://reviews.llvm.org/D83288





More information about the llvm-commits mailing list