[PATCH] D83605: [SelectionDAG][WebAssembly] Recognize splat value ABS operations

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 12 01:45:20 PDT 2020


RKSimon added a comment.

one minor in SelectionDAG - but a wasm dev needs to looks at the target code



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2317
+      return true;
+    }
+    break;
----------------
Unnecessary braces around the if()

And if you move the getOperand(0) inside the isSplatValue() call then the other braces can go as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83605/new/

https://reviews.llvm.org/D83605





More information about the llvm-commits mailing list