[PATCH] D78741: [LLD][ELF][AVR] Implement the missing relocation types

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Please check D83634 <https://reviews.llvm.org/D83634>. We can then enable --print-imm-hex

If the canonical comment marker of AVR is `;`, I think we should just use `; ` everywhere...



================
Comment at: lld/ELF/Arch/AVR.cpp:161
+    checkAlignment(loc, val, 2, rel);
+    const uint16_t target = ((val - 2) >> 1);
+    write16le(loc, (read16le(loc) & 0xfc07) | ((target & 0x7f) << 3));
----------------
Delete redundant parentheses: `((val - 2) >> 1)` -> `(val - 2) >> 1`


================
Comment at: lld/ELF/Arch/AVR.cpp:167
+    checkAlignment(loc, val, 2, rel);
+    const uint16_t target = ((val - 2) >> 1);
+    write16le(loc, (read16le(loc) & 0xf000) | (target & 0xfff));
----------------
Delete redundant parentheses


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78741/new/

https://reviews.llvm.org/D78741