[PATCH] D81631: Fix undefined behavior in Dwarf.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

In D81631#2141400 <https://reviews.llvm.org/D81631#2141400>, @linzj wrote:

> > - bool SameAsPrevCU = this == DD->getPrevCU(); +  const DwarfCompileUnit *PrevCU = DD->getPrevCU();
>
> Err, once you invoke getPrevCU, then a load-to-undefined instruction will be emitted. So  valgrind will still report this problem.  valgrind doesn't like undefined value's load.


Right you are! Don't mind me then :) thanks for walking me through it all!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81631/new/

https://reviews.llvm.org/D81631