[PATCH] D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 11 08:59:33 PDT 2020


benshi001 added a comment.

Concusion,

1. RISCV got improved

2. X86 got slight improved

3. For aarch64's test urem-seteq-nonzero.ll,

3.1. 2 cases have one more instruction emitted,
3.2. 2 other cases have one less instruction emitted,
3.3. 9 other 9 cases have no change in instruction amount, but have madd replaced by mul.
Since madd has larger latency than mul, I think my change also makes aarch64 optimized in total.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83153/new/

https://reviews.llvm.org/D83153





More information about the llvm-commits mailing list