[PATCH] D83097: [FileCheck] Implement -dump-input-filter

Fri Jul 10 21:07:00 PDT 2020

mehdi_amini added inline comments.

================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:455
+    case DumpInputFilterAll:
+      llvm_unreachable("unexpected DumpInputFilterAll");
+      break;
----------------
jdenny wrote:
> jdenny wrote:
> > mehdi_amini wrote:
> > > In a tool like FileCheck I rather err on the side of deterministically failing with a `report_fatal_error`
> > I don't object in principal, but I see no precedent for this in FileCheck.
> > 
> > Are you ok with this landing as is?  If FileCheck should generally use `report_fatal_error` instead of `llvm_unreachable`, I feel like that should be discussed in a separate review for all occurrences.
> Given your accept and the tone of your comment, I decided it's safe to land this as is.  I'm fine to revert or adjust if you feel this was the wrong decision.  And again, I'm open to a larger discussion about making this change throughout FileCheck.
LG

I don't think it has bitten anyone, so likely not worth the effort right now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83097/new/

https://reviews.llvm.org/D83097