[PATCH] D83506: [NFC] Add debug and stat counters to assume queries and assume builder

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Nice. LGTM, some nits to be fixed below.



================
Comment at: llvm/lib/Analysis/AssumeBundleQueries.cpp:9
 
+#define DEBUG_TYPE "assume-queries"
+
----------------
Style: Is usually below the includes.


================
Comment at: llvm/lib/Analysis/AssumeBundleQueries.cpp:173
                                Filter) {
+  NumAssumeQueries++;
+  if (!DebugCounter::shouldExecute(AssumeQueryCounter))
----------------
Style: Use pre-increments everywhere.


================
Comment at: llvm/lib/Analysis/AssumeBundleQueries.cpp:185
+            Filter(RK, II, &II->bundle_op_info_begin()[Elem.Index])) {
+          NumUsefullAssumeQueries++;
           return RK;
----------------
Same


================
Comment at: llvm/lib/Analysis/AssumeBundleQueries.cpp:199
+          Filter(RK, cast<Instruction>(U.getUser()), Bundle)) {
+        NumUsefullAssumeQueries++;
         return RK;
----------------
Same


================
Comment at: llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp:9
 
+#define DEBUG_TYPE "assume-builder"
+
----------------
Same.


================
Comment at: llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp:241
     }
+    NumAssumeBuilt++;
     return cast<IntrinsicInst>(CallInst::Create(
----------------
Same.


================
Comment at: llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp:352
+      else
+        NumAssumesRemoved++;
       Assume->eraseFromParent();
----------------
Same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83506/new/

https://reviews.llvm.org/D83506