[PATCH] D83576: [BasicAA] Fix -basicaa-recphi for geps with negative offsets

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:1672
+              isa<ConstantInt>(PV1GEP->idx_begin()) &&
+              cast<ConstantInt>(PV1GEP->idx_begin())->getSExtValue() >= 0) {
             isRecursive = true;
----------------
Please avoid getSExtValue() when you can, in favor of APInt methods.

Do we need to check the GEP is inbounds?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83576/new/

https://reviews.llvm.org/D83576