[PATCH] D78133: [PredicateInfo] Add additional RenamedOp field to PB.
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 10 13:50:42 PDT 2020
nikic added a comment.
I've added a test case in https://github.com/llvm/llvm-project/commit/a0b549602612fa2577068bcdcae3bfbc6c9c3264, which shows a case where the RenamedOp doesn't work quite right. In this case RenamedOp should always refer back to `%cmp` or `%x`, but ends up refering to `%cmp.0`, `%x.0` and `%x.0.1`. I don't think this matters in a practical way though, because we don't get any additional information from the dominated predicate infos. It still seems like we either shouldn't place those predicate infos (because they're redundant), or provide them with a correct RenamedOp though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78133/new/
https://reviews.llvm.org/D78133
More information about the llvm-commits
mailing list