[PATCH] D83578: [test] Replace a fragile lit feature (substitution in an argument place) with command -v

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 13:06:20 PDT 2020


hubert.reinterpretcast added a comment.

In D83578#2145020 <https://reviews.llvm.org/D83578#2145020>, @MaskRay wrote:

> Agreed that the lit feature is weird and should be removed. AFAIK I don't think the feature is used in other places. We should be able to drop the feature.


What you do mean by "in an argument place"? Does `llvm-ar` appear in an "argument place" in `not --crash llvm-ar` or `env -i LANG=C llvm-ar`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83578/new/

https://reviews.llvm.org/D83578





More information about the llvm-commits mailing list