[PATCH] D79630: AMDGPU: Start interpreting byref on kernel arguments

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 13:02:01 PDT 2020


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.h:164
 
-  void emitKernelArg(const DataLayout &DL, Type *Ty, ValueKind ValueKind,
+  void emitKernelArg(const DataLayout &DL, Type *Ty, Align Alignment, ValueKind ValueKind,
                      MaybeAlign PointeeAlign = None, StringRef Name = "",
----------------
This is too long.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79630/new/

https://reviews.llvm.org/D79630





More information about the llvm-commits mailing list