[PATCH] D83578: [test] Replace a fragile lit feature (substitution in an argument place) with command -v

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 11:49:43 PDT 2020


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

I believe if we do this without removing the substitutions, we're effectively running `EXE=$(command -v /full/path/to/llvm-ranlib)` which is a bit weird and IMO  doesn't make sense as a final state.

I haven't done much investigation into the history/motivation of these substitutions, but I imagine we can remove at least some of them, and I'm happy to help out.

How do you think we should sequence this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83578/new/

https://reviews.llvm.org/D83578





More information about the llvm-commits mailing list