[PATCH] D83578: [test] Replace a fragile lit feature (substitution in an argument place) with command -v

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 11:26:18 PDT 2020


MaskRay created this revision.
MaskRay added a reviewer: sammccall.
Herald added subscribers: llvm-commits, rupprecht, dexonsmith, steven_wu, hiraditya.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.

lit can do substitution in an argument place (like `llvm-ar` in `ln -s llvm-ar`) which
is counterintuitive. Replace the symlink mechanism with the more intuitive
`EXE=$(command -v)` (POSIX shell comformant).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83578

Files:
  llvm/test/tools/llvm-ar/tool-name.test
  llvm/test/tools/llvm-dlltool/tool-name.test
  llvm/test/tools/llvm-lib/tool-name.test
  llvm/test/tools/llvm-objcopy/tool-name.test
  llvm/test/tools/llvm-ranlib/tool-name.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83578.277108.patch
Type: text/x-patch
Size: 3747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200710/47e5a976/attachment.bin>


More information about the llvm-commits mailing list