[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 10:52:14 PDT 2020


MaskRay added a comment.

In D83013#2143470 <https://reviews.llvm.org/D83013#2143470>, @hans wrote:

> Still lgtm. For what it's worth, I think you could have just re-committed with the fixes rather than uploading for review again.


This may be a difference of habits but I usually upload the last revision if it contains anything more than comment changes. The reviewed version might be read by posterity to get a quick overview about the patch. Browsing git log -p is not very convenient at times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83013/new/

https://reviews.llvm.org/D83013





More information about the llvm-commits mailing list