[PATCH] D78741: [LLD][ELF][AVR] Implement the missing relocation types

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/avr-reloc.s:4
+# RUN: ld.lld %t.o --defsym=a=0x12345678 --defsym=b=30 -o %t
+# RUN: llvm-objdump -d %t | FileCheck %s
+# RUN: llvm-objdump -s %t | FileCheck --check-prefix=HEX %s
----------------
You may want `--print-imm-hex` to print immediates in hexadecimal.


================
Comment at: lld/test/ELF/avr-reloc.s:17
+# CHECK-NEXT:  ldi     r20, 255
+ldi r20, lo8(a)
+ldi r20, hi8(a)
----------------
Might be worth adding comments about the exact relocation type used, e.g.

`ldi r20, lo8(a)  # R_AVR_LO8_LDI...`


================
Comment at: lld/test/ELF/avr-reloc.s:80
+# HEX-LABEL: section .DATA:
+# HEX-NEXT:  1e1e000f 00785634 12
+.byte b
----------------
`{{.*}} 1e1e000f 00785634 12`

The address of .DATA is insignificant and should be omitted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78741/new/

https://reviews.llvm.org/D78741