[PATCH] D81788: [OpenMPOpt] ICV Tracking

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.
Herald added subscribers: okura, bbn.

I've reverted this in rG1d542f0ca83fa1411d6501a8d088450d83abd5b8.

There appears to be some kind of memory corruption/use-after-free/etc
going on here. In particular, in `OpenMPOpt::deleteParallelRegions()`,
in `DeleteCallCB()`, `CI` is garbage.

Reduced reproducer: `./bin/opt -O3 /tmp/test.ll`:

  ; ModuleID = '/home/lebedevri/CREDUCE/input.c'
  source_filename = "/home/lebedevri/CREDUCE/input.c"
  target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
  target triple = "x86_64-pc-linux-gnu"
  
  %struct.ident_t = type { i32, i32, i32, i32, i8* }
  
  @.str = private unnamed_addr constant [23 x i8] c";unknown;unknown;0;0;;\00", align 1
  @0 = private unnamed_addr global %struct.ident_t { i32 0, i32 2, i32 0, i32 0, i8* getelementptr inbounds ([23 x i8], [23 x i8]* @.str, i32 0, i32 0) }, align 8
  
  ; Function Attrs: nounwind uwtable
  define dso_local i32 @b() #0 {
    %1 = alloca i32, align 4
    %2 = call i32 @a()
    %3 = load i32, i32* %1, align 4
    ret i32 %3
  }
  
  ; Function Attrs: nounwind uwtable
  define internal i32 @a() #0 {
    %1 = alloca i32, align 4
    %2 = call i32 @b()
    call void (%struct.ident_t*, i32, void (i32*, i32*, ...)*, ...) @__kmpc_fork_call(%struct.ident_t* @0, i32 0, void (i32*, i32*, ...)* bitcast (void (i32*, i32*)* @.omp_outlined. to void (i32*, i32*, ...)*))
    %3 = load i32, i32* %1, align 4
    ret i32 %3
  }
  
  ; Function Attrs: norecurse nounwind uwtable
  define internal void @.omp_outlined.(i32* noalias %0, i32* noalias %1) #1 {
    %3 = alloca i32*, align 8
    %4 = alloca i32*, align 8
    store i32* %0, i32** %3, align 8, !tbaa !2
    store i32* %1, i32** %4, align 8, !tbaa !2
    ret void
  }
  
  ; Function Attrs: nounwind
  declare !callback !6 void @__kmpc_fork_call(%struct.ident_t*, i32, void (i32*, i32*, ...)*, ...) #2
  
  attributes #0 = { nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
  attributes #1 = { norecurse nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
  attributes #2 = { nounwind }
  
  !llvm.module.flags = !{!0}
  !llvm.ident = !{!1}
  
  !0 = !{i32 1, !"wchar_size", i32 4}
  !1 = !{!"Debian clang version 11.0.0-++20200709100646+c92a8c0a0f6-1~exp1~20200709201313.3348"}
  !2 = !{!3, !3, i64 0}
  !3 = !{!"any pointer", !4, i64 0}
  !4 = !{!"omnipotent char", !5, i64 0}
  !5 = !{!"Simple C/C++ TBAA"}
  !6 = !{!7}
  !7 = !{i64 2, i64 -1, i64 -1, i1 true}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81788/new/

https://reviews.llvm.org/D81788