[PATCH] D83370: [CallGraph] Ignore callback uses

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/IR/Function.cpp:1499
+      continue;
+
     const auto *Call = dyn_cast<CallBase>(FU);
----------------
You might need to inspect the ACS here. Check if it is really a callback callsite.


================
Comment at: llvm/test/Transforms/Attributor/IPConstantProp/pthreads.ll:104
-; IS__CGSCC_NPM-NEXT:  entry:
-; IS__CGSCC_NPM-NEXT:    ret i8* bitcast (i8** @GlobalVPtr to i8*)
 ;
----------------
TBH, this looks somehow we didn't run the script after a recent update. I'll commit an update to the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83370/new/

https://reviews.llvm.org/D83370