[PATCH] D82818: AMDGPU: Remove .value_type from kernel metadata

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:2321
 
-     "ValueType"       string         Required  Kernel argument value type. Only
-                                                present if "ValueKind" is
----------------
It looks like (according to phab diff) you removed space between "ValueType" and 'string', which will break the table.


================
Comment at: llvm/docs/AMDGPUUsage.rst:2322
+     "ValueType" string                         Unused and deprecated. This should no longer
+                                                be emitted, but is accepted for compatability.
+
----------------
compatibility


================
Comment at: llvm/docs/AMDGPUUsage.rst:2820-2842
-     ".value_type"          string         Required  Kernel argument value type. Only
-                                                     present if ".value_kind" is
-                                                     "by_value". For vector data
-                                                     types, the value is for the
-                                                     element type. Values include:
-
-                                                     - "struct"
----------------
Should same text apply as above? "Unused and deprecated. This should no longer..."


================
Comment at: llvm/include/llvm/Support/AMDGPUMetadata.h:82
 
-/// Value types.
+/// Value types. This is deprecated and only remains for compatability parsing
+/// of old metadata.
----------------
compatibility


================
Comment at: llvm/lib/Support/AMDGPUMetadata.cpp:115
+
+    // Removed. Accepted for parsing compatability, but not emitted.
+    Optional<ValueType> Unused;
----------------
same as above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82818/new/

https://reviews.llvm.org/D82818