[llvm] ef0ecb7 - [NFCI][InstCombine] PR46661: multiple stores eligible for merging into successor - worklist issue

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 07:49:52 PDT 2020


Author: Roman Lebedev
Date: 2020-07-10T17:49:16+03:00
New Revision: ef0ecb7b03332fd5076a7ea641eadf0d01cd32c0

URL: https://github.com/llvm/llvm-project/commit/ef0ecb7b03332fd5076a7ea641eadf0d01cd32c0
DIFF: https://github.com/llvm/llvm-project/commit/ef0ecb7b03332fd5076a7ea641eadf0d01cd32c0.diff

LOG: [NFCI][InstCombine] PR46661: multiple stores eligible for merging into successor - worklist issue

The testcase should pass with a single instcombine iteration.

Added: 
    llvm/test/Transforms/InstCombine/merging-multiple-stores-into-successor.ll

Modified: 
    

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/InstCombine/merging-multiple-stores-into-successor.ll b/llvm/test/Transforms/InstCombine/merging-multiple-stores-into-successor.ll
new file mode 100644
index 000000000000..f04897b6fb66
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/merging-multiple-stores-into-successor.ll
@@ -0,0 +1,74 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt %s -instcombine -instcombine-infinite-loop-threshold=4 -S | FileCheck %s
+
+ at var_7 = external global i8, align 1
+ at var_1 = external global i32, align 4
+ at var_0 = external global i16, align 2
+ at var_5 = external global i64, align 8
+ at arr_2 = external global [0 x i32], align 4
+ at arr_4 = external global [0 x i16], align 2
+ at arr_3 = external global [8 x i32], align 16
+
+define void @_Z4testv() {
+; CHECK-LABEL: @_Z4testv(
+; CHECK-NEXT:  bb:
+; CHECK-NEXT:    [[I:%.*]] = load i8, i8* @var_7, align 1
+; CHECK-NEXT:    [[I1:%.*]] = icmp eq i8 [[I]], -1
+; CHECK-NEXT:    [[I4:%.*]] = load i16, i16* @var_0, align 2
+; CHECK-NEXT:    [[I8:%.*]] = sext i16 [[I4]] to i32
+; CHECK-NEXT:    br i1 [[I1]], label [[BB10:%.*]], label [[BB9:%.*]]
+; CHECK:       bb9:
+; CHECK-NEXT:    br label [[BB12:%.*]]
+; CHECK:       bb10:
+; CHECK-NEXT:    [[I2:%.*]] = load i32, i32* @var_1, align 4
+; CHECK-NEXT:    [[I3:%.*]] = icmp eq i32 [[I2]], 0
+; CHECK-NEXT:    [[I6:%.*]] = load i64, i64* @var_5, align 8
+; CHECK-NEXT:    [[I5:%.*]] = sext i16 [[I4]] to i64
+; CHECK-NEXT:    [[I7:%.*]] = select i1 [[I3]], i64 [[I6]], i64 [[I5]]
+; CHECK-NEXT:    [[I11:%.*]] = trunc i64 [[I7]] to i32
+; CHECK-NEXT:    br label [[BB12]]
+; CHECK:       bb12:
+; CHECK-NEXT:    [[STOREMERGE1:%.*]] = phi i32 [ [[I11]], [[BB10]] ], [ 1, [[BB9]] ]
+; CHECK-NEXT:    [[STOREMERGE:%.*]] = phi i32 [ [[I11]], [[BB10]] ], [ 1, [[BB9]] ]
+; CHECK-NEXT:    store i32 [[STOREMERGE1]], i32* getelementptr inbounds ([0 x i32], [0 x i32]* @arr_2, i64 0, i64 0), align 4
+; CHECK-NEXT:    store i16 [[I4]], i16* getelementptr inbounds ([0 x i16], [0 x i16]* @arr_4, i64 0, i64 0), align 2
+; CHECK-NEXT:    store i32 [[I8]], i32* getelementptr inbounds ([8 x i32], [8 x i32]* @arr_3, i64 0, i64 0), align 16
+; CHECK-NEXT:    store i32 [[STOREMERGE]], i32* getelementptr inbounds ([0 x i32], [0 x i32]* @arr_2, i64 0, i64 1), align 4
+; CHECK-NEXT:    store i16 [[I4]], i16* getelementptr inbounds ([0 x i16], [0 x i16]* @arr_4, i64 0, i64 1), align 2
+; CHECK-NEXT:    store i32 [[I8]], i32* getelementptr inbounds ([8 x i32], [8 x i32]* @arr_3, i64 0, i64 1), align 4
+; CHECK-NEXT:    ret void
+;
+bb:
+  %i = load i8, i8* @var_7, align 1
+  %i1 = icmp eq i8 %i, -1
+  %i2 = load i32, i32* @var_1, align 4
+  %i3 = icmp eq i32 %i2, 0
+  %i4 = load i16, i16* @var_0, align 2
+  %i5 = sext i16 %i4 to i64
+  %i6 = load i64, i64* @var_5, align 8
+  %i7 = select i1 %i3, i64 %i6, i64 %i5
+  %i8 = sext i16 %i4 to i32
+  br i1 %i1, label %bb10, label %bb9
+
+bb9:                                              ; preds = %bb
+  store i32 1, i32* getelementptr inbounds ([0 x i32], [0 x i32]* @arr_2, i64 0, i64 0), align 4
+  store i16 %i4, i16* getelementptr inbounds ([0 x i16], [0 x i16]* @arr_4, i64 0, i64 0), align 2
+  store i32 %i8, i32* getelementptr inbounds ([8 x i32], [8 x i32]* @arr_3, i64 0, i64 0), align 4
+  store i32 1, i32* getelementptr inbounds ([0 x i32], [0 x i32]* @arr_2, i64 0, i64 1), align 4
+  store i16 %i4, i16* getelementptr inbounds ([0 x i16], [0 x i16]* @arr_4, i64 0, i64 1), align 2
+  store i32 %i8, i32* getelementptr inbounds ([8 x i32], [8 x i32]* @arr_3, i64 0, i64 1), align 4
+  br label %bb12
+
+bb10:                                             ; preds = %bb
+  %i11 = trunc i64 %i7 to i32
+  store i32 %i11, i32* getelementptr inbounds ([0 x i32], [0 x i32]* @arr_2, i64 0, i64 0), align 4
+  store i16 %i4, i16* getelementptr inbounds ([0 x i16], [0 x i16]* @arr_4, i64 0, i64 0), align 2
+  store i32 %i8, i32* getelementptr inbounds ([8 x i32], [8 x i32]* @arr_3, i64 0, i64 0), align 4
+  store i32 %i11, i32* getelementptr inbounds ([0 x i32], [0 x i32]* @arr_2, i64 0, i64 1), align 4
+  store i16 %i4, i16* getelementptr inbounds ([0 x i16], [0 x i16]* @arr_4, i64 0, i64 1), align 2
+  store i32 %i8, i32* getelementptr inbounds ([8 x i32], [8 x i32]* @arr_3, i64 0, i64 1), align 4
+  br label %bb12
+
+bb12:                                             ; preds = %bb10, %bb9
+  ret void
+}


        


More information about the llvm-commits mailing list