[PATCH] D83543: [CodeMoverUtils] Add more data dependency related test case

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 07:42:54 PDT 2020


Whitney added inline comments.


================
Comment at: llvm/unittests/Transforms/Utils/CodeMoverUtilsTest.cpp:698
+        EXPECT_TRUE(isSafeToMoveBefore(*LoadA0, *StoreA1, DT, &PDT, &DI));
+        // Anti forward dependency
+        EXPECT_FALSE(isSafeToMoveBefore(*StoreA1, *StoreB0, DT, &PDT, &DI));
----------------
should this be flow dependency? as the dependency is still read after write.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83543/new/

https://reviews.llvm.org/D83543





More information about the llvm-commits mailing list