[PATCH] D83284: [InstCombine] Improve select -> phi canonicalization: consider more blocks

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/select.ll:2286
+; CHECK:       exit:
+; CHECK-NEXT:    ret i32 [[B:%.*]]
+;
----------------
mkazantsev wrote:
> nikic wrote:
> > I don't understand why this returns `%B` (and what the difference to the previous test is, for that matter).
> It actually returns `%A`, `%B` here is just a regex name. Seems that I miscopied it on revase, it was supposed to exertice scenario
> ```
>   %sel = select i1 %cond, i32 %A, i32 %phi
> ```
Fixed the test `test_select_into_phi_not_idom_2` and var naming in it. It was supposed to show that we can replace Phi that is a false value of select (the previous test shows when it's a true value).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83284/new/

https://reviews.llvm.org/D83284