[llvm] b69e0f6 - DomTreeUpdater::dump() - use const auto& iterator in for-range-loop.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 04:48:21 PDT 2020


Author: Simon Pilgrim
Date: 2020-07-10T12:47:15+01:00
New Revision: b69e0f674fb5a05224fbe50cae9a9e4137a2c0e1

URL: https://github.com/llvm/llvm-project/commit/b69e0f674fb5a05224fbe50cae9a9e4137a2c0e1
DIFF: https://github.com/llvm/llvm-project/commit/b69e0f674fb5a05224fbe50cae9a9e4137a2c0e1.diff

LOG: DomTreeUpdater::dump() - use const auto& iterator in for-range-loop.

Avoids unnecessary copies and silences clang tidy warning.

Added: 
    

Modified: 
    llvm/lib/Analysis/DomTreeUpdater.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/DomTreeUpdater.cpp b/llvm/lib/Analysis/DomTreeUpdater.cpp
index e0e17de20121..26e637bb6d99 100644
--- a/llvm/lib/Analysis/DomTreeUpdater.cpp
+++ b/llvm/lib/Analysis/DomTreeUpdater.cpp
@@ -507,7 +507,7 @@ LLVM_DUMP_METHOD void DomTreeUpdater::dump() const {
 
   OS << "Pending DeletedBBs:\n";
   Index = 0;
-  for (auto BB : DeletedBBs) {
+  for (const auto &BB : DeletedBBs) {
     OS << "  " << Index << " : ";
     ++Index;
     if (BB->hasName())
@@ -519,7 +519,7 @@ LLVM_DUMP_METHOD void DomTreeUpdater::dump() const {
 
   OS << "Pending Callbacks:\n";
   Index = 0;
-  for (auto BB : Callbacks) {
+  for (const auto &BB : Callbacks) {
     OS << "  " << Index << " : ";
     ++Index;
     if (BB->hasName())


        


More information about the llvm-commits mailing list