[PATCH] D83097: [FileCheck] Implement -dump-input-filter

[Joel E. Denny via Phabricator via llvm-commits]

jdenny marked an inline comment as done.
jdenny added inline comments.


================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:455
+    case DumpInputFilterAll:
+      llvm_unreachable("unexpected DumpInputFilterAll");
+      break;
----------------
mehdi_amini wrote:
> In a tool like FileCheck I rather err on the side of deterministically failing with a `report_fatal_error`
I don't object in principal, but I see no precedent for this in FileCheck.

Are you ok with this landing as is?  If FileCheck should generally use `report_fatal_error` instead of `llvm_unreachable`, I feel like that should be discussed in a separate review for all occurrences.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83097/new/

https://reviews.llvm.org/D83097