[PATCH] D83440: [InstSimplify] Re-enable select ?, undef, X -> X transform when X is provably not poison

Fri Jul 10 02:05:49 PDT 2020

brooksmoses added a comment.

In D83440#2143461 <https://reviews.llvm.org/D83440#2143461>, @nlopes wrote:

> Yes, it may hide some warnings.
>  But that's life. Optimizations do hide programming errors. This is not the only one for sure. But it's ok as you are checking the code that will run. If the compiler can "fix" bugs automatically, then developers don't need to worry about those. As long as you keep running these checks continuously to track changes in the compiler like this one :)

Fair point, and thanks for the perspective!  :)  Even though I seem to have gotten "lucky" (or unlucky?) with this case, I'm sure that point will be relevant sooner or later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83440/new/

https://reviews.llvm.org/D83440