[PATCH] D83440: [InstSimplify] Re-enable select ?, undef, X -> X transform when X is provably not poison
Brooks Moses via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 10 01:41:42 PDT 2020
brooksmoses added a comment.
I'd erroneously made this comment on the revision (where I think nobody will see it) rather than here, so copying it here:
A question about this: We got a couple of dozen MSAN warnings in the Google codebase from the revision that removed these -- I'm guessing that perhaps what happened was that the undef in question was a use-of-uninitialized-value, and this optimization was hiding the use so the MSAN checks didn't trigger. Is re-enabling this going to make those MSAN warnings go away again, re-hiding this undefined behavior?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83440/new/
https://reviews.llvm.org/D83440
More information about the llvm-commits
mailing list