[PATCH] D83289: [BPF] Emit unknown types as byte arrays

Yonghong Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 22:06:54 PDT 2020


yonghong-song added a comment.

Thanks for the change. LGTM. Could you add some warnings for these unsupported types (using llvm::errs())? Without this patch, BTF will be rejected. This patch will make them pass
verifier. Warning will let user know the program has unsupported types or certain limitations and these types and limitations are worked around by the compiler. People may report
these types and limitations back to bpf community so we can evaluate whether we need to extend BTF to have proper support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83289/new/

https://reviews.llvm.org/D83289





More information about the llvm-commits mailing list