[PATCH] D83326: [flang][openmp] Check clauses allowed semantic with tablegen generated map

[Brian Yang via Phabricator via llvm-commits]

ichoyjx added inline comments.


================
Comment at: flang/test/Semantics/omp-clause-validity01.f90:457
 
-  !ERROR: REDUCTION clause is not allowed on the TASKLOOP SIMD directive
   !$omp taskloop simd reduction(+:a)
----------------
clementval wrote:
> As a side note, This is supposed to be fine in Clang so I removed the check. I looked at the OpenMP 5.0 std and didn't see a restriction on `reduction` for `task loop simd`.
What's the current plan? Are we trying to cover OpenMP 5.0 Spec for semantics (it appears so)?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:229
     VersionedClause<OMPC_Allocate>,
     VersionedClause<OMPC_Detach, 50>,
     VersionedClause<OMPC_Affinity, 50>
----------------
Bear with me, what does 50 mean?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:427
     VersionedClause<OMPC_Map>,
-    VersionedClause<OMPC_NoWait>,
-    VersionedClause<OMPC_Depend>
+    VersionedClause<OMPC_NoWait>
+  ];
----------------
For `target enter` and `target exit`, `nowait` is only allowed once. If it's allowed here, will this restriction be captured by the rules in `target` directive above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83326/new/

https://reviews.llvm.org/D83326