[PATCH] D83526: [FileCheck] In input dump, elide only if ellipsis is shorter

[Joel E. Denny via Phabricator via llvm-commits]

jdenny created this revision.
jdenny added reviewers: probinson, thopre, jhenderson, mehdi_amini.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

For example, given `-dump-input-context=3 -vv`, the following now 
shows more leading context for the error than requested because a
leading ellipsis would occupy the same number of lines as it would
elide:

  <<<<<<
           1: foo6
           2: foo5
           3: foo4
           4: foo3
           5: foo2
           6: foo1
           7: hello world
  check:1     ^~~~~
  check:2           X~~~~ error: no match found
           8: foo1
  check:2     ~~~~
           9: foo2
  check:2     ~~~~
          10: foo3
  check:2     ~~~~
           .
           .
           .
  >>>>>>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83526

Files:
  llvm/test/FileCheck/dump-input-context.txt
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83526.276884.patch
Type: text/x-patch
Size: 13234 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200710/ac38e0c1/attachment.bin>