[PATCH] D83431: [Docs] CodingStandards: for_each is discouraged
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 9 13:11:23 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG29a9dd5bfe50: [Docs] CodingStandards: for_each is discouraged (authored by lebedev.ri).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83431/new/
https://reviews.llvm.org/D83431
Files:
llvm/docs/CodingStandards.rst
Index: llvm/docs/CodingStandards.rst
===================================================================
--- llvm/docs/CodingStandards.rst
+++ llvm/docs/CodingStandards.rst
@@ -1302,6 +1302,9 @@
for (Instruction &I : *BB)
... use I ...
+Usage of ``std::for_each()``/``llvm::for_each()`` functions is discouraged,
+unless the the callable object already exists.
+
Don't evaluate ``end()`` every time through a loop
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83431.276817.patch
Type: text/x-patch
Size: 479 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200709/ebed0b3e/attachment-0001.bin>
More information about the llvm-commits
mailing list