[PATCH] D83498: [NFC] Derive from PassInfoMixin for no-op/printing passes

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 12:05:07 PDT 2020


ychen added a comment.

I was aware of this recently. Thanks for fixing this. Just one nit. Please wait for one other reviewer.



================
Comment at: llvm/lib/Passes/PassBuilder.cpp:300
 
-namespace {
+namespace llvm {
 
----------------
How about keeping this local? These are only for testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83498/new/

https://reviews.llvm.org/D83498





More information about the llvm-commits mailing list