[PATCH] D81981: [PGO] Supplement PGO profile with Sample profile
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 9 11:03:27 PDT 2020
davidxl added inline comments.
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:293
+static void writeInstrProfile(StringRef OutputFilename,
+ ProfileFormat OutputFormat,
----------------
this refactoring can also be committed independently
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:553
+ std::unique_ptr<WriterContext> WC;
+ // Make sure Inputs[i] is sample profile and Inputs[i - 1] is
+ // instrumentation profile.
----------------
make sample file path as the part of the option, so there is no need to handle the ordering.
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:568
+ adjustInstrProfiles(WC, Reader,
+ Inputs[i].Weight / (double)Inputs[1 - i].Weight,
+ EarlyInlineSizeThreshold, BaseScaleFunction);
----------------
Are these two weights comparable?
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:872
+ cl::opt<std::string> BaseScaleFunction(
+ "base-scale-function", cl::init(""), cl::Hidden,
+ cl::desc("When supplementing an instrumentation profile with sample "
----------------
Is this flag tested?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81981/new/
https://reviews.llvm.org/D81981
More information about the llvm-commits
mailing list