[PATCH] D83311: [CodeMoverUtils] Add optional data dependence checks using MSSA

[rithik sharma via Phabricator via llvm-commits]

RithikSharma marked an inline comment as done.
RithikSharma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:368
   // Skip tests when we don't have PDT or DI
-  if (!PDT || !DI)
+  if (!PDT || !(DI || MSSAU))
     return false;
----------------
fhahn wrote:
> RithikSharma wrote:
> > fhahn wrote:
> > > Does it make sense to even call this function if either of those are not available, i.e. if all those required wouldn't it make sense to assert that they are all provided or turn them into references?
> > I'm sorry, I didn't understand. We need at least DI or MSSA to find dependency. 
> I meant does it make sense to call this function without  `PDT == nullptr` for example? It seems like it is kind of required here, right?
Got it, why is PDT not a reference if it is required, right? Most code motion clients example LICM don't have PDT so until we find a way to prove control flow equivalence with some other analysis we need to keep the !PDT check but we did changed PDT into pointer as we will be expecting nullptr in near future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83311/new/

https://reviews.llvm.org/D83311