[PATCH] D83421: [RFC] MemorySSAUpdater: Simplify applyUpdates

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

In D83421#2141875 <https://reviews.llvm.org/D83421#2141875>, @nhaehnle wrote:

> Okay, thank you for that context, that makes sense. I'm going to drop this change then obviously.
>
> FYI, I'm considering to at least try out making dominator tree construction based on the CfgInterfaceImpl from D83088 <https://reviews.llvm.org/D83088>, so that GenericDomTreeConstruction is no longer all a giant ball of templates. Do you think this would help you with your changes? Obviously there's the question of how it impacts compile time, but we won't really know for sure until we try it, which is one of my motivations here.


I think it's a great idea to improve GenericDomTreeConstruction. Some of the already committed patches did some nice cleanups. I don't have a clear picture yet of what the overlap/conflict will be with D77341 <https://reviews.llvm.org/D77341>, but we can work this out as you sent out more changes. I'll send out an update on the RFC as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83421/new/

https://reviews.llvm.org/D83421